linux-kernel - Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22cb4ca8-7114-4162-b4a4-ded70d2a69d1@collabora.com>
Date: Wed, 21 Feb 2024 10:55:51 +0200
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Venkata Prasad Potturu <venkataprasad.potturu@....com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
 Liam Girdwood <lgirdwood@...il.com>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Daniel Baluta <daniel.baluta@....com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>, Mark Brown
 <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Cc: sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct
 acp_quirk_entry

On 2/21/24 08:14, Venkata Prasad Potturu wrote:
> 
> On 2/21/24 01:46, Cristian Ciocaltea wrote:
>> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
>> signed firmware support in the driver via the acp_sof_quirk_table.
>>
>> In preparation to support additional use cases of the quirk table (i.e.
>> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
>> and update all references to it accordingly.
>>
>> No functional changes intended.
> 
> If there are no new flags currently being used in this patch, and also
> no functional changes added, in this case this patch is really required?

I would say yes, as it improves the ACP SOF quirk handling by making the
implementation more readable, less error prone and open for extension,
as already mentioned.

Additionally, it should facilitate the review process, since it's
unaffected by any potential changes that might be required for the
subsequent patch.

> Also please use scripts/get_maintainer.pl in CC while sending patches,
> then only
> maintainers get notified your changes.

I've already done that. Did I miss something?

Regards,
Cristian