linux-kernel - Re: [PATCH stable] memcg: add refcnt for pcpu stock to avoid UAF problem in drain_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdXU6QAujPI27ita@tiehlicka>
Date: Wed, 21 Feb 2024 11:48:09 +0100
From: Michal Hocko <mhocko@...e.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: "GONG, Ruiqi" <gongruiqi1@...wei.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Shakeel Butt <shakeelb@...gle.com>,
	Muchun Song <muchun.song@...ux.dev>, cgroups@...r.kernel.org,
	linux-mm@...ck.org, Wang Weiyang <wangweiyang2@...wei.com>,
	Xiu Jianfeng <xiujianfeng@...wei.com>
Subject: Re: [PATCH stable] memcg: add refcnt for pcpu stock to avoid UAF
 problem in drain_all_stock()

On Wed 21-02-24 11:33:55, Greg KH wrote:
> On Wed, Feb 21, 2024 at 09:48:05AM +0100, Michal Hocko wrote:
> > On Wed 21-02-24 09:40:29, Greg KH wrote:
> > > On Wed, Feb 21, 2024 at 04:18:01PM +0800, GONG, Ruiqi wrote:
> > > > commit 1a3e1f40962c445b997151a542314f3c6097f8c3 upstream.
> > > > 
> > > > There was a kernel panic happened on an in-house environment running
> > > > 3.10, and the same problem was reproduced on 4.19:
> > > 
> > > Now queued up, thanks!
> > 
> > Give it some more time Greg, http://lkml.kernel.org/r/ZdW2gMajIw_cUN2-@tiehlicka
> 
> Oops, now dropped, thanks!

Race conditions. The thing got resolved in the mean time. The patch is a
partial backport, and I am OK with that. Now with my questions resolved
this is good to know but a note about this being a partial backport in
the changelog would be nice.

-- 
Michal Hocko
SUSE Labs