linux-kernel - Re: [PATCH] power: supply: axp288_fuel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 11:58:56 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Guoyi Zhang <kuoi@...archlinux.org>, sre@...nel.org, wens@...e.org
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X

Hi,

On 2/21/24 09:34, Guoyi Zhang wrote:
> The ROCK Pi X is a single board computer without batteries using the
> AXP288 PMIC where the EFI code does not disable the charger part of 
> the PMIC causing us to report a discharging battery with a continuously
> consumed battery charge to userspace.
> 
> Add it to the deny-list to avoid the bogus battery status reporting.
> 
> Signed-off-by: Guoyi Zhang <kuoi@...archlinux.org>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>  drivers/power/supply/axp288_fuel_gauge.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 3be6f3b10..8f67f5d0d 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -599,6 +599,14 @@ static const struct dmi_system_id axp288_quirks[] = {
>  		},
>  		.driver_data = NULL,
>  	},
> +	{
> +		/* Radxa ROCK Pi X Single Board Computer */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "ROCK Pi X"),
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Radxa"),
> +		},
> +		.driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
> +	},
>  	{
>  		/*
>  		 * Various Ace PC/Meegopad/MinisForum/Wintel Mini-PCs/HDMI-sticks