linux-kernel - Re: [PATCH v8 2/5] perf: util: use capstone disasm engine to show assembly instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjZO+URmNE0SQBrFR5-rsLobNpYdiT4s=5svCUwoYbRVQ@mail.gmail.com>
Date: Tue, 20 Feb 2024 18:04:36 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: Changbin Du <changbin.du@...wei.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>, 
	Thomas Richter <tmricht@...ux.ibm.com>, changbin.du@...il.com, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v8 2/5] perf: util: use capstone disasm engine to show
 assembly instructions

Hi Adrian and Changbin,

On Sun, Feb 18, 2024 at 10:33 PM Adrian Hunter <adrian.hunter@...elcom> wrote:
>
> On 17/02/24 09:40, Changbin Du wrote:
> > Currently, the instructions of samples are shown as raw hex strings
> > which are hard to read. x86 has a special option '--xed' to disassemble
> > the hex string via intel XED tool.
> >
> > Here we use capstone as our disassembler engine to give more friendly
> > instructions. We select libcapstone because capstone can provide more
> > insn details. Perf will fallback to raw instructions if libcapstone is
> > not available.
> >
> > The advantages compared to XED tool:
> >  * Support arm, arm64, x86-32, x86_64 (more could be supported),
> >    xed only for x86_64.
> >  * Immediate address operands are shown as symbol+offs.
> >
> > Signed-off-by: Changbin Du <changbin.du@...wei.com>
>
> This is the only patch of V8 that made it to my inbox, Namhyung
> also mentioned problems receiving V7, but the patches are on lore.
>
> For whole patch set:
>
> Reviewed-by: Adrian Hunter <adrian.hunter@...el.com>

I found it in my spam box, maybe there was a change in the spam
filtering logic.

Thanks,
Namhyung