linux-kernel - Re: [PATCH 6.1 000/197] 6.1.79-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 13:37:30 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc: Daniel Díaz <daniel.diaz@...aro.org>,
	stable@...r.kernel.org, patches@...ts.linux.dev,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
	patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
	jonathanh@...dia.com, f.fainelli@...il.com,
	sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
	conor@...nel.org, allen.lkml@...il.com,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 6.1 000/197] 6.1.79-rc1 review

On Wed, Feb 21, 2024 at 09:16:32AM +0100, Matthias Schiffer wrote:
> On Tue, 2024-02-20 at 19:40 -0600, Daniel Díaz wrote:
> > ********************
> > Achtung externe E-Mail: Öffnen Sie Anhänge und Links nur, wenn Sie wissen, dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten Sie die E-Mail im Zweifelsfall zur Prüfung an den IT-Helpdesk weiter.
> > Attention external email: Open attachments and links only if you know that they are from a secure source and are safe. In doubt forward the email to the IT-Helpdesk to check it.
> > ********************
> > 
> > Hello!
> > 
> > On 20/02/24 7:04 p. m., Daniel Díaz wrote:
> > > On 20/02/24 2:49 p. m., Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.79 release.
> > > > There are 197 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Thu, 22 Feb 2024 20:48:08 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.79-rc1.gz
> > > > or in the git tree and branch at:
> > > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > 
> > > We see a regression with PowerPC:
> > > 
> > > -----8<-----
> > >    /builds/linux/arch/powerpc/kernel/cpu_setup_6xx.S: Assembler messages:
> > >    /builds/linux/arch/powerpc/kernel/cpu_setup_6xx.S:124: Error: unrecognized opcode: `sym_func_start_local(setup_g2_le_hid2)'
> > >    /builds/linux/arch/powerpc/kernel/cpu_setup_6xx.S:131: Error: unrecognized opcode: `sym_func_end(setup_g2_le_hid2)'
> > >    make[4]: *** [/builds/linux/scripts/Makefile.build:382: arch/powerpc/kernel/cpu_setup_6xx.o] Error 1
> > > ----->8-----
> > > 
> > > This is seen only on PowerPC with GCC 8, GCC 13, Clang 17, Clang nightly, on:
> > > * allnoconfig
> > > * tinyconfig
> > > * mpc83xx_defconfig
> > > * ppc6xx_defconfig
> > > (at least)
> > > 
> > > Reproducer:
> > > 
> > >    tuxmake \
> > >      --runtime podman \
> > >      --target-arch powerpc \
> > >      --toolchain gcc-8 \
> > >      --kconfig tinyconfig
> > > 
> > 
> > Bisection points to:
> > 
> >    commit a65d7a833f486d0c162fdc854d2d5dd2e66ddd95
> >    Author: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> >    Date:   Wed Jan 24 11:38:38 2024 +0100
> > 
> >        powerpc/6xx: set High BAT Enable flag on G2_LE cores
> >        
> >        [ Upstream commit a038a3ff8c6582404834852c043dadc73a5b68b4 ]
> > 
> > 
> > Reverting that commit makes the build pass again.
> 
> It seems that backporting the mentioned commit verbatim would also require
> 2da37761671b5bdedbe04e6469cfa57cd6b6ae45 ("powerpc/32: Fix objtool unannotated intra-function call
> warnings") to make SYM_FUNC_START_LOCAL/SYM_FUNC_END available. Please drop this patch from 6.1 and
> older for now.

Now dropped, thanks!

greg k-h