linux-kernel - Re: [PATCH] rtc: max31335: fix interrupt status reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca7d78f6cffc49eba7bb44134c85e94279f1ce95.camel@gmail.com>
Date: Wed, 21 Feb 2024 14:30:03 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>, Alexandre Belloni
	 <alexandre.belloni@...tlin.com>, Guenter Roeck <linux@...ck-us.net>, 
	linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: max31335: fix interrupt status reg

On Mon, 2024-02-19 at 11:16 +0200, Antoniu Miclaus wrote:
> Fix the register value comparison in the `max31335_volatile_reg`
> function for the interrupt status register.
> 
> MAX31335_STATUS1 macro definition corresponds to the actual
> interrupt status register.
> 
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/rtc/rtc-max31335.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 402fda8fd548..a2441e5c2c74 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -204,7 +204,7 @@ static bool max31335_volatile_reg(struct device *dev, unsigned
> int reg)
>  		return true;
>  
>  	/* interrupt status register */
> -	if (reg == MAX31335_INT_EN1_A1IE)
> +	if (reg == MAX31335_STATUS1)
>  		return true;
>  
>  	/* temperature registers */