linux-kernel - Re: [PATCH v2 20/20] media: venus: pm_helpers: Use reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 14:34:45 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, Stanimir Varbanov
 <stanimir.k.varbanov@...il.com>, Vikash Garodia
 <quic_vgarodia@...cinc.com>,  Bryan O'Donoghue
 <bryan.odonoghue@...aro.org>, Andy Gross <agross@...nel.org>, Bjorn
 Andersson <andersson@...nel.org>,  Mauro Carvalho Chehab
 <mchehab@...nel.org>, Dikshita Agarwal <quic_dikshita@...cinc.com>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>, Stanimir Varbanov
	 <stanimir.varbanov@...aro.org>, Mauro Carvalho Chehab
	 <mchehab+huawei@...nel.org>, linux-media@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 20/20] media: venus: pm_helpers: Use reset_bulk API

On Mi, 2024-02-14 at 22:20 +0100, Konrad Dybcio wrote:
> On 14.02.2024 14:31, Philipp Zabel wrote:
> > Hi Konrad,
> > 
> > On Fr, 2024-02-09 at 22:10 +0100, Konrad Dybcio wrote:
> > > All of the resets are toggled together. Use the bulk api to save on some
> > > code complexity.
> > > 
> > > The delay between resets is now correctly determined by the reset
> > > framework.
> > 
> > If this is a recent change, could you reference the commit?
> 
> It's a series that recently landed in -next [1]

Missing link?

> [...]
> 
> > 
> > Since VIDC_RESETS_NUM_MAX is only 2, I don't think a separate
> > allocation is worth it.
> 
> It's 2 today, anyway. I wanted to keep it flexible

If this is expected to grow, fine.

> [...]
> 
> > > +	ret = reset_control_bulk_reset(res->resets_num, core->resets);
> > > +	if (ret)
> > > +		dev_err(core->dev, "Failed to toggle resets: %d\n", ret);
> > >  
> > > -err:
> > >  	return ret;
> > 
> > Could be simplified to:
> > 
> > 	return reset_control_bulk_reset(res->resets_num, core-
> > > resets);
> 
> I intentionally kept the if (ret) to print a specific error message
> in case the call fails, this driver doesn't go a good job of telling
> the user/developer what went wrong.

Oh, ok.

regards
Philipp