[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZdX8gTpgqyM/jjvp@bfoster>
Date: Wed, 21 Feb 2024 08:37:05 -0500
From: Brian Foster <bfoster@...hat.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Kent Overstreet <kent.overstreet@...ux.dev>,
linux-bcachefs@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] bcachefs: remove redundant assignment to variable
ret
On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote:
> Variable ret is being assigned a value that is never read, it is
> being re-assigned a couple of statements later on. The assignment
> is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
Reviewed-by: Brian Foster <bfoster@...hat.com>
> fs/bcachefs/super-io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/bcachefs/super-io.c b/fs/bcachefs/super-io.c
> index 110dcb0337ce..c6d590404425 100644
> --- a/fs/bcachefs/super-io.c
> +++ b/fs/bcachefs/super-io.c
> @@ -804,7 +804,6 @@ static int __bch2_read_super(const char *path, struct bch_opts *opts,
> goto err;
> }
>
> - ret = 0;
> sb->have_layout = true;
>
> ret = bch2_sb_validate(sb, &err, READ);
> --
> 2.39.2
>
Powered by blists - more mailing lists