linux-kernel - Re: [PATCH] ext4: forbid commit inconsistent quota data when errors=remount-ro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170861726752.823885.428276685390671750.b4-ty@mit.edu>
Date: Thu, 22 Feb 2024 10:54:35 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        Ye Bin <yebin10@...wei.com>
Cc: "Theodore Ts'o" <tytso@....edu>, linux-kernel@...r.kernel.org,
        jack@...e.cz
Subject: Re: [PATCH] ext4: forbid commit inconsistent quota data when errors=remount-ro


On Fri, 19 Jan 2024 14:29:08 +0800, Ye Bin wrote:
> There's issue as follows When do IO fault injection test:
> Quota error (device dm-3): find_block_dqentry: Quota for id 101 referenced but not present
> Quota error (device dm-3): qtree_read_dquot: Can't read quota structure for id 101
> Quota error (device dm-3): do_check_range: Getting block 2021161007 out of range 1-186
> Quota error (device dm-3): qtree_read_dquot: Can't read quota structure for id 661
> 
> Now, ext4_write_dquot()/ext4_acquire_dquot()/ext4_release_dquot() may commit
> inconsistent quota data even if process failed. This may lead to filesystem
> corruption.
> To ensure filesystem consistent when errors=remount-ro there is need to call
> ext4_handle_error() to abort journal.
> 
> [...]

Applied, thanks!

[1/1] ext4: forbid commit inconsistent quota data when errors=remount-ro
      commit: d8b945fa475f13d787df00c26a6dc45a3e2e1d1d

Best regards,
-- 
Theodore Ts'o <tytso@....edu>