linux-kernel - Re: [PATCH] dt-bindings: usb: analogix,anx7411: drop redundant connector properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 22 Feb 2024 16:08:45 +0000
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Xin Ji <xji@...logixsemi.com>,
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] dt-bindings: usb: analogix,anx7411: drop redundant
 connector properties

On Thu, Feb 22, 2024 at 09:28:19AM +0100, Krzysztof Kozlowski wrote:
> The binding references usb-connector.yaml schema, which lists all
> allowed properties and ends with unevaluatedProperties:false, so we can
> simplify analogix,anx7411 binding by dropping everything covered by
> usb-connector.yaml.
> 
> Suggested-by: Pavel Machek <pavel@....cz>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  .../devicetree/bindings/usb/analogix,anx7411.yaml   | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> index e4d893369d57..3f5857aee3b0 100644
> --- a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> @@ -23,24 +23,11 @@ properties:
>    connector:
>      type: object
>      $ref: ../connector/usb-connector.yaml
> -    unevaluatedProperties: false

The connector schema sets `additionalProperties: true`. Is removing this
correct?


> -
> -    description:
> -      Properties for usb c connector.
>  
>      properties:
>        compatible:
>          const: usb-c-connector
>  
> -      power-role: true
> -
> -      data-role: true
> -
> -      try-power-role: true
> -
> -    required:
> -      - compatible
> -
>  required:
>    - compatible
>    - reg
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)