linux-kernel - Re: [PATCH net-next] ipv6/sit: Do not allocate stats in the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <032f132f-274d-4a23-82b8-fcc4393f7954@kernel.org>
Date: Thu, 22 Feb 2024 10:32:22 -0700
From: David Ahern <dsahern@...nel.org>
To: Breno Leitao <leitao@...ian.org>, kuba@...nel.org, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, horms@...nel.org
Subject: Re: [PATCH net-next] ipv6/sit: Do not allocate stats in the driver

On 2/21/24 9:17 AM, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the ipv6/sit driver and leverage the network
> core allocation.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  net/ipv6/sit.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>