linux-kernel - Re: [PATCH][next] bcachefs: remove redundant assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27hacgxfzyeatjx27nb4k5rb5cajt5yw4c2papfr4h64urb7qx@teo2ha6msqnl>
Date: Wed, 21 Feb 2024 19:13:04 -0500
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: "Colin King (gmail)" <colin.i.king@...il.com>
Cc: Brian Foster <bfoster@...hat.com>, linux-bcachefs@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] bcachefs: remove redundant assignment to variable
 ret

On Thu, Feb 22, 2024 at 12:08:28AM +0000, Colin King (gmail) wrote:
> On 22/02/2024 00:04, Kent Overstreet wrote:
> > On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote:
> > > Variable ret is being assigned a value that is never read, it is
> > > being re-assigned a couple of statements later on. The assignment
> > > is redundant and can be removed.
> > > 
> > > Cleans up clang scan build warning:
> > > fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is
> > > never read [deadcode.DeadStores]
> > > 
> > > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> > 
> > I'll take this, but - entirely too much of the traffic on this list is
> > getting taken up by static analyzer bullshit, we need to cut down on
> > this
> 
> I'll back off then.

Maybe just wrap up fixes for all the warnings every now and then? It is
worth keeping up on static analyzer warnings, it's just the mailing list
noise I want to cut down on, as well as making better use of my own
time.

I'd be happy to take a patch like that now and then, or - maybe we could
get a dashboard going, like I was just running by Dan in the other
thread? If we could get a dirt simple stupid dashboard that had both the
clangc analyzer warnings, and the smatch warnings - I think that would
make a lot of people happy.