linux-kernel - Re: [PATCH] cred: Use KMEM_CACHE instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f51c6ba-a6c0-4fbf-9b00-21cea6d59ca9@kylinos.cn>
Date: Thu, 22 Feb 2024 11:04:55 +0800
From: Kunwu Chan <chentao@...inos.cn>
To: Paul Moore <paul@...l-moore.com>
Cc: axboe@...nel.dk, elena.reshetova@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cred: Use KMEM_CACHE instead of kmem_cache_create

Thanks for your reply.
On 2024/2/22 08:10, Paul Moore wrote:
> On Thu, Feb 15, 2024 at 10:54 PM Paul Moore <paul@...l-moore.com> wrote:
>> On Tue, Jan 30, 2024 at 4:40 AM Kunwu Chan <chentao@...inos.cn> wrote:
>>>
>>> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>>> introduces a new macro.
>>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>>> to simplify the creation of SLAB caches.
>>>
>>> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
>>> ---
>>>   kernel/cred.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> This seems reasonable to me, unless I see any objections I can pull
>> this via the LSM tree next week.
> 
> Actually, never mind, the original posting has some non-ASCII junk in
> the patch and I'm not able to import it cleanly.
Thanks for reply.

I checked the patch with the checkpatch.pl script and applied it to 
another machine to compile and found no issues.
Seems ok to me, what should I do next to clean up that non-ASCII junk.

And i use :perl -ne 'print if /[^[:ascii:]]/' 
0001-cred-Use-KMEM_CACHE-instead-of-kmem_cache_create.patch seems ok too.
> 
-- 
Thanks,
   Kunwu