lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 22 Feb 2024 19:18:34 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yang Xiwen <forbidden405@...look.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: David Yang <mmyangfl@...il.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/8] ARM: dts: hisilicon: add missing compatibles to
 CRG node

On 22/02/2024 19:13, Yang Xiwen wrote:
> On 2/23/2024 2:08 AM, Krzysztof Kozlowski wrote:
>> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote:
>>> From: Yang Xiwen <forbidden405@...look.com>
>>>
>>> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent
>>> binding changes.
>> Why? You claimed you added them in the bindings because DTS has them. In
>> DTS you claim reason is: binding has them.
>>
>> That's confusing.
> 
> 
> Because the old txt based binding claimed there should not be a "syscon" 
> and "simple-mfd".
> 
> 
> But it exists in hi3798cv200.dtsi. And i think it does no harm to be 
> there. So should i do it in two commits?

hi3798cv200 is not hi3519, is it? You are adding simple-mfd to one SoC
because some other has it? I don't see reason to do that. Er, why?

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ