linux-kernel - Re: [PATCH][next][V2] ACPI: thermal_lib: Initialize temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 22 Feb 2024 20:37:44 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Zhang Rui <rui.zhang@...el.com>, Len Brown <lenb@...nel.org>, 
	linux-acpi@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next][V2] ACPI: thermal_lib: Initialize temp_decik to zero

On Thu, Feb 22, 2024 at 11:57 AM Colin Ian King <colin.i.king@...ilcom> wrote:
>
> Static analysis with clang scan build is warning that uninitialized
> data is being passed into various functions. Stop these warnings by
> initializing temp_decik to zero.
>
> Cleans up clang scan warnings in lines 106, 125, 146 and 164 such as:
> drivers/acpi/thermal_lib.c:106:9: warning: 2nd function call argument
> is an uninitialized value [core.CallAndMessage]
>
> Kudos to Dan Carpenter for the deeper analysis of this issue.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>
> V2: just set temp_decik to 0
>
> ---
>  drivers/acpi/thermal_lib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
> index 4e0519ca9739..6214d6ebe1fa 100644
> --- a/drivers/acpi/thermal_lib.c
> +++ b/drivers/acpi/thermal_lib.c
> @@ -100,7 +100,7 @@ static int thermal_temp(int error, int temp_decik, int *ret_temp)
>   */
>  int thermal_acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
>  {
> -       int temp_decik;
> +       int temp_decik = 0;
>         int ret = acpi_active_trip_temp(adev, id, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> @@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_active_trip_temp);
>   */
>  int thermal_acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
>  {
> -       int temp_decik;
> +       int temp_decik = 0;
>         int ret = acpi_passive_trip_temp(adev, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> @@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_passive_trip_temp);
>   */
>  int thermal_acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
>  {
> -       int temp_decik;
> +       int temp_decik = 0;
>         int ret = acpi_hot_trip_temp(adev, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> @@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_hot_trip_temp);
>   */
>  int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
>  {
> -       int temp_decik;
> +       int temp_decik = 0;
>         int ret = acpi_critical_trip_temp(adev, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> --

Applied as 6.9 material, thanks!