linux-kernel - Re: virtcrypto_dataq_callback calls crypto_finalize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240222153106-mutt-send-email-mst@kernel.org>
Date: Thu, 22 Feb 2024 15:31:23 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: "Gonglei (Arei)" <arei.gonglei@...wei.com>
Cc: Halil Pasic <pasic@...ux.ibm.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Jason Wang <jasowang@...hat.com>,
	"virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	Marc Hartmayer <mhartmay@...ux.ibm.com>
Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request() from
 irq context

On Thu, Nov 02, 2023 at 01:25:31PM +0000, Gonglei (Arei) wrote:
> 
> 
> > -----Original Message-----
> > From: Michael S. Tsirkin [mailto:mst@...hat.com]
> > Sent: Thursday, November 2, 2023 9:17 PM
> > To: Gonglei (Arei) <arei.gonglei@...wei.com>
> > Cc: Halil Pasic <pasic@...ux.ibm.com>; Herbert Xu
> > <herbert@...dor.apana.org.au>; Jason Wang <jasowang@...hat.com>;
> > virtualization@...ts.linux-foundation.org; linux-kernel@...r.kernel.org;
> > linux-crypto@...r.kernel.org; Marc Hartmayer <mhartmay@...ux.ibm.com>
> > Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request() from irq
> > context
> > 
> > On Thu, Nov 02, 2023 at 01:04:07PM +0000, Gonglei (Arei) wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Michael S. Tsirkin [mailto:mst@...hat.com]
> > > > Sent: Wednesday, November 1, 2023 9:26 PM
> > > > To: Halil Pasic <pasic@...ux.ibm.com>
> > > > Cc: Gonglei (Arei) <arei.gonglei@...wei.com>; Herbert Xu
> > > > <herbert@...dor.apana.org.au>; Jason Wang <jasowang@...hat.com>;
> > > > virtualization@...ts.linux-foundation.org;
> > > > linux-kernel@...r.kernel.org; linux-crypto@...r.kernel.org; Marc
> > > > Hartmayer <mhartmay@...ux.ibm.com>
> > > > Subject: Re: virtcrypto_dataq_callback calls
> > > > crypto_finalize_request() from irq context
> > > >
> > > > On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic wrote:
> > > > > On Sun, 24 Sep 2023 11:56:25 +0000 "Gonglei (Arei)"
> > > > > <arei.gonglei@...wei.com> wrote:
> > > > >
> > > > > > Hi Halil,
> > > > > >
> > > > > > Commit 4058cf08945 introduced a check for detecting crypto
> > > > > > completion function called with enable BH, and indeed the
> > > > > > virtio-crypto driver didn't disable BH, which needs a patch to fix it.
> > > > > >
> > > > > > P.S.:
> > > > > > https://lore.kernel.org/lkml/20220221120833.2618733-5-clabbe@bay
> > > > > > libr
> > > > > > e.com/T/
> > > > > >
> > > > > > Regards,
> > > > > > -Gonglei
> > > > >
> > > > > Thanks Gonglei!
> > > > >
> > > > > Thanks! I would be glad to test that fix on s390x. Are you about
> > > > > to send one?
> > > > >
> > > > > Regards,
> > > > > Halil
> > > >
> > > >
> > > > Gonglei did you intend to send a fix?
> > >
> > > Actually I sent a patch a month ago, pls see another thread.
> > >
> > >
> > > Regards,
> > > -Gonglei
> > 
> > And I think there was an issue with that patch that you wanted to fix?
> > config changed callback got fixed but this still didn't.
> > 
> Now my concern is whether or not the judgement (commit 4058cf08945c1) is reasonable.
> 
> Regards,
> -Gonglei

So what is the plan to deal with the issue?

-- 
MST