linux-kernel - Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2792937.BEx9A2HvPv@jernej-laptop>
Date: Thu, 22 Feb 2024 21:57:00 +0100
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: linux-kernel@...r.kernel.org, Aren Moynihan <aren@...cevolution.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
 Jean-Jacques Hiblot <jjhiblot@...phandler.com>, Chen-Yu Tsai <wens@...e.org>,
 Ondrej Jirman <megi@....cz>, linux-sunxi@...ts.linux.dev,
 Lee Jones <lee@...nel.org>, Pavel Machek <pavel@....cz>,
 linux-arm-kernel@...ts.infradead.org, linux-leds@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, Miles Alan <m@...esalan.com>,
 Samuel Holland <samuel@...lland.org>, Aren Moynihan <aren@...cevolution.org>
Subject:
 Re: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to
 status

Dne torek, 06. februar 2024 ob 19:13:20 CET je Aren Moynihan napisal(a):
> The status function is described in the documentation as being a rgb led
> used for system notifications on phones[1][2]. This is exactly what this
> led is used for on the PinePhone, so using status is probably more
> accurate than indicator.
> 
> 1: Documentation/leds/well-known-leds.txt
> 2: include/dt-bindings/leds/common.h
> 
> Signed-off-by: Aren Moynihan <aren@...cevolution.org>

Sorry for late review.

Please update subject in patches 2-3. Instead of "sun50i-a64-pinephone:"
use "allwinner: pinephone:" (check commit history of sun50i-a64-pinephone.dtsi).
Also rgb -> RGB, led -> LED. Last, please reword commit message to exclude
links and just say DT bindings documentation.

Note that I'll merge patches 2-3 once patch 1 is merged.

Best regards,
Jernej

> ---
> I can't find any documentation describing the indicator function, so
> it's definitely less specific than status, but besides that I'm not sure
> how it compares. Please ignore this patch if it's not useful.
> 
> (no changes since v1)
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index e53e0d4579a7..6d327266e6cc 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -61,7 +61,7 @@ led2: led-2 {
>  	multi-led {
>  		compatible = "leds-group-multicolor";
>  		color = <LED_COLOR_ID_RGB>;
> -		function = LED_FUNCTION_INDICATOR;
> +		function = LED_FUNCTION_STATUS;
>  		leds = <&led0>, <&led1>, <&led2>;
>  	};
>  
>