linux-kernel - Re: [PATCH 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdbcwrQG1etZkb3j@skv.local>
Date: Thu, 22 Feb 2024 08:33:54 +0300
From: Andrey Skvortsov <andrej.skvortzov@...il.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Alain Volmat <alain.volmat@...s.st.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ondřej Jirman <megi@....cz>,
	Pavel Machek <pavel@....cz>,
	Arnaud Ferraris <arnaud.ferraris@...labora.com>
Subject: Re: [PATCH 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP
 bus support

Hi Sakari,

On 24-02-20 10:47, Sakari Ailus wrote:
> On Tue, Feb 20, 2024 at 10:46:23AM +0000, Sakari Ailus wrote:
> > Hi Andrey,
> > 
> > Thanks for the patchset.
> > 
> > On Sun, Feb 18, 2024 at 01:03:07AM +0300, Andrey Skvortsov wrote:
> > > Don't require link-frequencies like it's done for ov5640, that
> > > supports both CSI-2 and DVP. And v4l2_fwnode_endpoint_alloc_parse
> > > ignores link-frequencies property for DVP endpoint. It's used only for
> > > CSI-2 endpoints
> > > 
> > > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@...il.com>
> > > ---
> > >  .../bindings/media/i2c/galaxycore,gc2145.yaml | 33 +++++++++++++++++--
> > >  1 file changed, 30 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > > index 1726ecca4c77..fb376b9d0f2a 100644
> > > --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > > +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> > > @@ -61,9 +61,6 @@ properties:
> > >          properties:
> > >            link-frequencies: true
> > >  
> > > -        required:
> > > -          - link-frequencies
> > 
> > That seems like a bad idea to me.
> > 
> > While for parallel interface it may not be often important, for CSI-2 it
> > should stay.
> 
> You're also missing the bus-type property which should default to CSI-2
> D-PHY.

I'll add this type and make link-frequencies required based on that
for CSI-2 bus.

-- 
Best regards,
Andrey Skvortsov