[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdUJi3khMmRXRquwKNF1ezEAokLs+n46O2JDDap6t9v=tQ@mail.gmail.com>
Date: Thu, 22 Feb 2024 10:19:03 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mmc: sh_mmcif: sg_miter does not need to be atomic
Hi Linus,
On Wed, Feb 21, 2024 at 10:23 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> All the sglist iterations happen in the *threaded* interrupt handler
> and that context is not atomic, so don't request an atomic
> sglist miter. Using an atomic miter results in "BUG: scheduling while
> atomic" splats.
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Fixes: 27b57277d9ba ("mmc: sh_mmcif: Use sg_miter for PIO")
> Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> Hi Geert, it'd be great if you could test this!
Done before (see the Tb above ;-)
You probably still want to s/does not need to/must not/?
(sorry, I miswrote that previously)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists