linux-kernel - Re: [PATCH net v3] net: sparx5: Add spinlock for frame transmission from CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 22 Feb 2024 01:20:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, lars.povlsen@...rochip.com, Steen.Hegelund@...rochip.com,
 daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com,
 rmk+kernel@...linux.org.uk, u.kleine-koenig@...gutronix.de,
 yuehaibing@...wei.com, vladimir.oltean@....com,
 bjarni.jonasson@...rochip.com, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] net: sparx5: Add spinlock for frame transmission from
 CPU

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 19 Feb 2024 09:00:43 +0100 you wrote:
> Both registers used when doing manual injection or fdma injection are
> shared between all the net devices of the switch. It was noticed that
> when having two process which each of them trying to inject frames on
> different ethernet ports, that the HW started to behave strange, by
> sending out more frames then expected. When doing fdma injection it is
> required to set the frame in the DCB and then make sure that the next
> pointer of the last DCB is invalid. But because there is no locks for
> this, then easily this pointer between the DCB can be broken and then it
> would create a loop of DCBs. And that means that the HW will
> continuously transmit these frames in a loop. Until the SW will break
> this loop.
> Therefore to fix this issue, add a spin lock for when accessing the
> registers for manual or fdma injection.
> 
> [...]

Here is the summary with links:
  - [net,v3] net: sparx5: Add spinlock for frame transmission from CPU
    https://git.kernel.org/netdev/net/c/603ead96582d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html