[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fbdcd6e6-9d57-47d8-a462-908a03b373ea@quicinc.com>
Date: Thu, 22 Feb 2024 16:20:05 +0530
From: Odelu Kukatla <quic_okukatla@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <djakov@...nel.org>
CC: <rafael@...nel.org>, <corbet@....net>, <linux-pm@...r.kernel.org>,
<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<quic_viveka@...cinc.com>, <peterz@...radead.org>,
<quic_mdtipton@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<konrad.dybcio@...aro.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: interconnect: add clock property to
configure QoS on SC7280
On 2/5/2024 8:40 PM, Krzysztof Kozlowski wrote:
> On 05/02/2024 15:56, Odelu Kukatla wrote:
>> Added clock property to enable clocks required for accessing
>> qos registers.
>
> I have no idea how you came up with that CC list. It makes no sense.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries. Tomorrow.
>
> Best regards,
> Krzysztof
>
Thanks for your comments. I used latest tree only, but looks like i made a mistake while sending it.
I will use scripts/get_maintainer.pl script to get the list for next revision with other's comments addressed.
Thanks,
Odelu
Powered by blists - more mailing lists