linux-kernel - Re: [PATCH v2 0/4] Add support for QoS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddef6339-6a37-4048-80f0-7c008ec51cf0@quicinc.com>
Date: Thu, 22 Feb 2024 16:24:46 +0530
From: Odelu Kukatla <quic_okukatla@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <djakov@...nel.org>
CC: <rafael@...nel.org>, <corbet@....net>, <linux-pm@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_viveka@...cinc.com>, <peterz@...radead.org>,
        <quic_mdtipton@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <krzysztof.kozlowski@...aro.org>, <quic_rlaggysh@...cinc.com>
Subject: Re: [PATCH v2 0/4] Add support for QoS configuration



On 2/6/2024 2:37 PM, Konrad Dybcio wrote:
> 
> 
> On 2/5/24 15:56, Odelu Kukatla wrote:
>> This series adds QoS support for QNOC type device which can be found on
>> SC7280 platform. It adds support for programming priority,
>> priority forward disable and urgency forwarding. This helps in
>> priortizing the traffic originating from different interconnect masters
>> at NOC(Network On Chip).
>>
>> Changes in v2:
>>   - Updated regmap_update to make use GENMASK and FIELD_PREP.
>>   - Removed the regmap structure from qcom_icc_node.
>>   - Made qcom_icc_rpmh_configure_qos() static
>>   - Removed qcom_icc_rpmh_map() API, inlined the code in probe
>>     function.
>>   - Updated declarations to reverse christmas tree fashion.
> 
> You ignored some of my previous review comments without a response.
> 
> Konrad

Thanks Konrad! i replied to all of your comments.
I will send V3 with all the comments addressed.

Thanks,
Odelu