linux-kernel - Re: [PATCH 03/11] crypto: qce - Convert register r/w for skcipher via BAM/DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4af8317-776f-7530-51af-9cf42eab7b01@quicinc.com>
Date: Thu, 22 Feb 2024 16:56:19 +0530
From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
To: Md Sadre Alam <quic_mdalam@...cinc.com>, <thara.gopinath@...il.com>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
        <linux-crypto@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <quic_varada@...cinc.com>
Subject: Re: [PATCH 03/11] crypto: qce - Convert register r/w for skcipher via
 BAM/DMA



On 12/14/2023 5:12 PM, Md Sadre Alam wrote:
> Convert register read/write for skcipher via BAM/DMA.
> with this change all the crypto register configuration
> will be done via BAM/DMA. This change will prepare command
> descriptor for all register and write it once.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@...cinc.com>
> ---
>   drivers/crypto/qce/common.c   | 42 +++++++++++++++++++++--------------
>   drivers/crypto/qce/skcipher.c | 12 ++++++++++
>   2 files changed, 37 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
> index 04253a8d3340..d1da6b1938f3 100644
> --- a/drivers/crypto/qce/common.c
> +++ b/drivers/crypto/qce/common.c

  Changes to common.c should have been in patch #2 ?
  Btw, if we are making cmd desc approach as default for all socs
  we should have it tested in all platforms ?

Regards,
  Sricharan