linux-kernel - Re: [PATCH] mm, thp: display [never] for defrag when THP is set to never

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec6f2c48-3010-4a02-8f42-fc6b912039cf@redhat.com>
Date: Thu, 22 Feb 2024 13:14:58 +0100
From: David Hildenbrand <david@...hat.com>
To: Yuanhe Shu <xiangzao@...ux.alibaba.com>, akpm@...ux-foundation.org
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 liusong@...ux.alibaba.com
Subject: Re: [PATCH] mm, thp: display [never] for defrag when THP is set to
 never

On 22.02.24 12:53, Yuanhe Shu wrote:
> When transparent_hugepage is set to never by cmdline or echo, defrag
> still show what it used to be and can be modified which makes user
> confusing whether defrag would take effect.
> 
> Actually if transparent_hugepage is set to never, defrag will not take
> effect. Just Display never and remain unchangeable to for defrag when
> transparent_hugepage is set to never.
> 
> Suggested-by: Liu Song <liusong@...ux.alibaba.com>
> Signed-off-by: Yuanhe Shu <xiangzao@...ux.alibaba.com>
> ---

No, I don't think we want such a dependency between both options.

You might just end up breaking existing scripts (enable defrag before 
enabling THP) for no good reason.

-- 
Cheers,

David / dhildenb