linux-kernel - Re: [PATCH md-6.9 00/10] md/raid1: refactor read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6BE93F19-AF6B-4E05-ABFC-24FC7DF97524@intel.com>
Date: Thu, 22 Feb 2024 13:04:46 +0000
From: "Luse, Paul E" <paul.e.luse@...el.com>
To: Yu Kuai <yukuai1@...weicloud.com>
CC: Paul Menzel <pmenzel@...gen.mpg.de>, Paul E Luse
	<paul.e.luse@...ux.intel.com>, "song@...nel.org" <song@...nel.org>,
	"neilb@...e.com" <neilb@...e.com>, "shli@...com" <shli@...com>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"yi.zhang@...wei.com" <yi.zhang@...wei.com>, "yangerkun@...wei.com"
	<yangerkun@...wei.com>, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH md-6.9 00/10] md/raid1: refactor read_balance() and some
 minor fix



> On Feb 22, 2024, at 2:08 AM, Yu Kuai <yukuai1@...weicloud.com> wrote:
> 
> Hi,
> 
> 在 2024/02/22 16:40, Paul Menzel 写道:
>> Is there a change in performance with the current patch set? Is radi1 well enough covered by the test suite?
> 
> Yes, there are no performance degradation, and mdadm tests passed. And
> Paul Luse also ran fio mixed workload w/data integrity and it passes.
> 
> Thanks,
> Kuai
> 

Kuai is correct, in my original perf improvement patch I included lots of results.  For this set where we just refactored I checked performance to assure we didn't go downhill but didn't save the results as deltas were in the noise.  After this series lands we will look at introducing performance improvements again and at that time results from a full performance sweep will be included.  

For data integrity, 1 and 2 disk mirrors were ran overnight w/fio and crcr32 check - no issues.

To assure other code paths execute as they did before was a little trickier without a unit test framework but for those cases I did modify/un-modify the code several times to follow various code paths and assure they're working as expected (ie bad blocks, etc)

-Paul