[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240222141622.GA2748112-robh@kernel.org>
Date: Thu, 22 Feb 2024 07:16:22 -0700
From: Rob Herring <robh@...nel.org>
To: Seven Lee <wtli@...oton.com>
Cc: broonie@...nel.org, lgirdwood@...il.com, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
conor+dt@...nel.org, YHCHuang@...oton.com, KCHSU0@...oton.com,
CTLIN0@...oton.com, SJLIN0@...oton.com, scott6986@...il.com,
supercraig0719@...il.com, dardar923@...il.com
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: Added schema for
"nuvoton,nau8325"
On Thu, Feb 22, 2024 at 04:38:24PM +0800, Seven Lee wrote:
> Added a DT schema for describing nau8325 audio amplifiers.
Please test your bindings before sending.
>
> Signed-off-by: Seven Lee <wtli@...oton.com>
> ---
> .../bindings/sound/nuvoton,nau8325.yaml | 82 +++++++++++++++++++
> 1 file changed, 82 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml
> new file mode 100644
> index 000000000000..fc72baf0bb7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nuvoton,nau8325.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NAU8325 audio Amplifier
> +
> +maintainers:
> + - Seven Lee <WTLI@...oton.com>
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: nuvoton,nau8325
> +
> + reg:
> + maxItems: 1
> +
> + nuvoton,vref-impedance:
> + $ref: /schemas/types.yaml#/definitions/uint32
Use standard unit suffixes.
> + description:
> + VREF impedance selection.
> + enum:
> + - 0 # Open
> + - 1 # 25kOhm
> + - 2 # 125kOhm
> + - 3 # 2.5kOhm
> + default: 2
> +
> + nuvoton,dac-vref:
> + $ref: /schemas/types.yaml#/definitions/uint32
Use standard unit suffixes.
> + description:
> + DAC Reference Voltage Setting.
> + enum:
> + - VDDA
in Volts?
> + - VDDA*1.5/1.8V
Volts/Volts
So 2 different units?
> + - VDDA*1.6/1.8V
> + - VDDA*1.7/1.8V
> + default: 2
> +
> + nuvoton,alc-enable:
> + description:
> + Enable digital automatic level control (ALC) function.
> + type: boolean
> +
> + nuvoton,clock-detection-disable:
> + description:
> + When clock detection is enabled, it will detect whether MCLK
> + and FS are within the range. MCLK range is from 2.048MHz to 24.576MHz.
> + FS range is from 8kHz to 96kHz.
> + type: boolean
> +
> + nuvoton,clock-det-data:
> + description:
> + Request clock detection to require 2048 non-zero samples before enabling
> + the audio paths. If set then non-zero samples is required, otherwise it
> + doesn't matter.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + codec@21 {
> + compatible = "nuvoton,nau8325";
> + reg = <0x21>;
> + nuvoton,vref-impedance = <2>;
> + nuvoton,dac-vref = <2>;
> + nuvoton,alc-enable;
> + nuvoton,clock-det-data;
> + };
> + };
> --
> 2.25.1
>
Powered by blists - more mailing lists