linux-kernel - Re: [PATCH v3 2/3] power: supply: Add Acer Aspire 1 embedded controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 16:04:36 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Nikita Travkin <nikita@...n.ru>
Cc: Hans de Goede <hdegoede@...hat.com>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	cros-qcom-dts-watchers@...omium.org, Andy Gross <agross@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, 
	Rob Herring <robh@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3 2/3] power: supply: Add Acer Aspire 1 embedded
 controller driver

Hi,

On Fri, Feb 23, 2024 at 07:32:17PM +0500, Nikita Travkin wrote:
> >> + This driver provides battery and AC status support for the mentioned
> > 
> > I did not see any AC status bits?
> 
> I was referring to whatever ACPI spec calls "AC Adapter" but I guess
> I should have used the word "charger" instead... Will reword this.

But you only register a power-supply device for the battery and not
for the AC adapter/charger. When you write "and AC status support" I
would have expected something similar to this (that's from ACPI AC
adapter driver):

$ cat /sys/class/power_supply/AC/uevent
POWER_SUPPLY_NAME=AC
POWER_SUPPLY_TYPE=Mains
POWER_SUPPLY_ONLINE=1

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)