[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zdiz9lWiCJ9Sg0bQ@smile.fi.intel.com>
Date: Fri, 23 Feb 2024 17:04:22 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Peter Collingbourne <pcc@...gle.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
stable@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: Do not reclock if already at correct
rate
On Thu, Feb 22, 2024 at 11:26:34AM -0800, Peter Collingbourne wrote:
> When userspace opens the console, we call set_termios() passing a
> termios with the console's configured baud rate. Currently this causes
> dw8250_set_termios() to disable and then re-enable the UART clock at
> the same frequency as it was originally. This can cause corruption
> of any concurrent console output. Fix it by skipping the reclocking
> if we are already at the correct rate.
Makes sense to me from code perspective.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists