linux-kernel - Re: [PATCH v8 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86il2f2jov.wl-maz@kernel.org>
Date: Fri, 23 Feb 2024 17:07:28 +0000
From: Marc Zyngier <maz@...nel.org>
To: <ankita@...dia.com>
Cc: <jgg@...dia.com>,
	<oliver.upton@...ux.dev>,
	<james.morse@....com>,
	<suzuki.poulose@....com>,
	<yuzenghui@...wei.com>,
	<reinette.chatre@...el.com>,
	<surenb@...gle.com>,
	<stefanha@...hat.com>,
	<brauner@...nel.org>,
	<catalin.marinas@....com>,
	<will@...nel.org>,
	<mark.rutland@....com>,
	<alex.williamson@...hat.com>,
	<kevin.tian@...el.com>,
	<yi.l.liu@...el.com>,
	<ardb@...nel.org>,
	<akpm@...ux-foundation.org>,
	<andreyknvl@...il.com>,
	<wangjinchao@...sion.com>,
	<gshan@...hat.com>,
	<shahuang@...hat.com>,
	<ricarkol@...gle.com>,
	<linux-mm@...ck.org>,
	<lpieralisi@...nel.org>,
	<rananta@...gle.com>,
	<ryan.roberts@....com>,
	<david@...hat.com>,
	<linus.walleij@...aro.org>,
	<bhe@...hat.com>,
	<aniketa@...dia.com>,
	<cjia@...dia.com>,
	<kwankhede@...dia.com>,
	<targupta@...dia.com>,
	<vsethi@...dia.com>,
	<acurrid@...dia.com>,
	<apopple@...dia.com>,
	<jhubbard@...dia.com>,
	<danw@...dia.com>,
	<kvmarm@...ts.linux.dev>,
	<mochs@...dia.com>,
	<zhiw@...dia.com>,
	<kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device

On Tue, 20 Feb 2024 07:29:25 +0000,
<ankita@...dia.com> wrote:
> 
> From: Ankit Agrawal <ankita@...dia.com>
> 
> To provide VM with the ability to get device IO memory with NormalNC
> property, map device MMIO in KVM for ARM64 at stage2 as NormalNC.
> Having NormalNC S2 default puts guests in control (based on [1],
> "Combining stage 1 and stage 2 memory type attributes") of device
> MMIO regions memory mappings. The rules are summarized below:
> ([(S1) - stage1], [(S2) - stage 2])
> 
> S1           |  S2           | Result
> NORMAL-WB    |  NORMAL-NC    | NORMAL-NC
> NORMAL-WT    |  NORMAL-NC    | NORMAL-NC
> NORMAL-NC    |  NORMAL-NC    | NORMAL-NC
> DEVICE<attr> |  NORMAL-NC    | DEVICE<attr>
> 
> Still this cannot be generalized to non PCI devices such as GICv2.
> There is insufficient information and uncertainity in the behavior
> of non PCI driver. A driver must indicate support using the
> new flag VM_ALLOW_ANY_UNCACHED.
> 
> Adapt KVM to make use of the flag VM_ALLOW_ANY_UNCACHED as indicator to
> activate the S2 setting to NormalNc.
> 
> [1] section D8.5.5 of DDI0487J_a_a-profile_architecture_reference_manual.pdf
> 
> Suggested-by: Catalin Marinas <catalin.marinas@....com>
> Acked-by: Jason Gunthorpe <jgg@...dia.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Ankit Agrawal <ankita@...dia.com>

Since people have asked for various commit message updates, I'll add
my own: for the KVM/arm64 tree, the convention for the subject line is
"KVM: arm64: Something starting with a capital".

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.