[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZdjZCrpP52Hfbs6L@smile.fi.intel.com>
Date: Fri, 23 Feb 2024 19:42:34 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@...el.com>
Cc: linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clkdev: Update clkdev id usage to allow for longer
names
On Fri, Feb 23, 2024 at 11:35:16AM -0500, Michael J. Ruhl wrote:
> clkdev DEV ID information is limited to an array of 20 bytes
> (MAX_DEV_ID). It is possible that the ID could be longer than
> that. If so, the lookup will fail because the "real ID" will
> not match the copied value.
>
> For instance, generating a device name for the I2C Designware
> module using the PCI ID can result in a name of:
>
> i2c_designware.39424
>
> clkdev_create() will store:
>
> i2c_designware.3942
>
> The stored name is one off and will not match correctly during probe.
>
> Increase the size of the ID to allow for a longer name.
> v2: Removed CON_ID update and added example to commit
Usually we put changelog out of the commit messages...
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@...el.com>
> ---
..somewhere here.
Also just noticed that you forgot CCF maintainers to be included.
I'm suggesting to use my script [1] which harvests more or less
adequate list of people and mailing lists to Cc email to.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists