linux-kernel - Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240223-register-snowbound-b837c8b1cc25@spud>
Date: Fri, 23 Feb 2024 18:17:37 +0000
From: Conor Dooley <conor@...nel.org>
To: Lee Jones <lee@...nel.org>
Cc: Conor Dooley <conor.dooley@...rochip.com>, Pavel Machek <pavel@....cz>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low

On Fri, Feb 23, 2024 at 03:43:04PM +0000, Lee Jones wrote:
> On Tue, 13 Feb 2024, Conor Dooley wrote:
> 
> > From: Conor Dooley <conor.dooley@...rochip.com>
> > 
> > active-low was lifted to the common schema for leds, but it went
> > unnoticed that the leds-multicolour binding had "additionalProperties:
> > false" where the other users had "unevaluatedProperties: false", thereby
> > disallowing active-low for multicolour leds. Explicitly permit it again.
> > 
> > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> > ---
> > 
> > I'm just assuming this is intentionally restrictive, if its not, we
> > could easily just change this to uneval: false.
> > 
> > CC: Pavel Machek <pavel@....cz>
> > CC: Lee Jones <lee@...nel.org>
> > CC: Rob Herring <robh@...nel.org>
> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> > CC: Conor Dooley <conor+dt@...nel.org>
> > CC: Sven Schwermer <sven.schwermer@...ruptive-technologies.com>
> > CC: Christian Marangi <ansuelsmth@...il.com>
> > CC: linux-leds@...r.kernel.org
> > CC: devicetree@...r.kernel.org
> > CC: linux-kernel@...r.kernel.org
> > ---
> >  Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > index 5edfbe347341..a31a202afe5c 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> > @@ -41,6 +41,8 @@ properties:
> >  
> >            pwm-names: true
> >  
> > +          active-low: true
> > +
> >            color: true
> >  
> >          required:
> > -- 
> > 2.43.0
> 
> Neither checkpatch.pl or Git appear to be happy with this:

18:15:26 conor /stuff/linux$ shazam 20240213-verse-clinic-e6de06e1f18d@...d
Grabbing thread from lore.kernel.org/all/20240213-verse-clinic-e6de06e1f18d@...d/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 3 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
Retrieving CI status, may take a moment...
---
  ✓ [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low
    + Acked-by: Rob Herring <robh@...nel.org> (✓ DKIM/kernel.org)
  ---
  ✓ Signed: openpgp/conor.dooley@...rochip.com (From: conor@...nel.org)
  ✓ Signed: DKIM/kernel.org
---
Total patches: 1
---
Applying: dt-bindings: leds: pwm-multicolour: re-allow active-low
18:15:39 conor /stuff/linux$ git show HEAD~1
commit 2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e (tag: next-20240220, korg-next/master)

What do you use to apply patches? b4 seems to have no trouble.

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)