linux-kernel - Re: [PATCH v4 1/2] arm64: dts: qcom: ipq6018: add LDOA2 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 11:10:20 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: andersson@...nel.org
Cc: amadeus@....edu.cn,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	konrad.dybcio@...aro.org,
	krzysztof.kozlowski+dt@...aro.org,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	robh+dt@...nel.org,
	robimarko@...il.com
Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: ipq6018: add LDOA2 regulator

Hi, Bjorn
> I still don't see a patch that does "something-supply = <&ipq6018_l2>;",
> which would imply that the main thing this patch achieves is that the
> regulator framework might turn the regulator off after a while.

> Shouldn't there be a user of ipq6018_l2?

Although there is the sdhc node in ipq6018-cp01-c1 in the qsdk kernel,
I don't have the official rdp board of qca, so I can't test it.

Normally it looks like this:

&sdhc {
	bus-width = <4>;
	cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
    ... /* specific properties */
	pinctrl-0 = <&sdhci_pins>;
	pinctrl-names = "default";
	vqmmc-supply = <&ipq6018_l2>;
	status = "okay";
};

As for actual routers, there are users.
One of the examples is on openwrt, a development board like 8devices:
https://github.com/openwrt/openwrt/blob/main/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq6010-mango-dvk.dts#L272

	vqmmc-supply = <&ipq6018_l2>;
	cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
..

The function of this node is to reference sd/emmc supply for devices
with pmic. Please let me know if it doesn't fit in this patch series
and I will deal with this in another pmic patch series.

Thanks,
Chukun

-- 
2.25.1