linux-kernel - Re: [PATCH v3 1/3] perf stat: Pass fewer metric arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 13:14:38 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	linux-perf-users@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ian Rogers <irogers@...gle.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	K Prateek Nayak <kprateek.nayak@....com>,
	Kajol Jain <kjain@...ux.ibm.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Kaige Ye <ye@...ge.org>,
	Mark Rutland <mark.rutland@....com>,
	John Garry <john.g.garry@...cle.com>,
	Jiri Olsa <jolsa@...nel.org>
Cc: Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v3 1/3] perf stat: Pass fewer metric arguments

On Tue, 20 Feb 2024 23:07:52 -0800, Ian Rogers wrote:
> Pass metric_expr and evsel rather than specific variables from the
> struct, thereby reducing the number of arguments. This will enable
> later fixes.
> 
> To reduce the size of the diff, local variables are added to match the
> previous parameter names. This isn't done in the case of "name" as
> evsel->name is more intention revealing. A whitespace issue is also
> addressed.
> 
> [...]

Applied to perf-tools-next, thanks!

[1/3] perf stat: Pass fewer metric arguments
      commit: eee41e6b287e2adfefbe3b6fc80c66097c076f89
[2/3] perf metrics: Compute unmerged uncore metrics individually
      commit: a59fb796a36bb6c2b7e6e256a9e5f9ba18109937
[3/3] perf stat: Fix metric-only aggregation index
      commit: bafd4e75c1ac5a9da0aec5c7c52c7a72613a0cf3

Best regards,
-- 
Namhyung Kim <namhyung@...nel.org>