linux-kernel - Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 15:07:58 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Marcos Paulo de Souza <mpdesouza@...e.com>,
 Yujie Liu <yujie.liu@...el.com>
Cc: kernel test robot <lkp@...el.com>, Josh Poimboeuf <jpoimboe@...nel.org>,
 Jiri Kosina <jikos@...nel.org>, Miroslav Benes <mbenes@...e.cz>,
 Petr Mladek <pmladek@...e.com>, Joe Lawrence <joe.lawrence@...hat.com>,
 oe-kbuild-all@...ts.linux.dev, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR

On 2/21/24 19:04, Marcos Paulo de Souza wrote:
> On Thu, 22 Feb 2024 09:28:19 +0800 Yujie Liu <yujie.liu@...el.com> wrote:
> 
>> On Wed, Feb 21, 2024 at 07:04:03PM -0300, Marcos Paulo de Souza wrote:
>>> On Wed, 21 Feb 2024 14:12:00 -0700 Shuah Khan <skhan@...uxfoundation.org> wrote:
>>>
>>>> On 2/21/24 05:26, Marcos Paulo de Souza wrote:
>>>>> On Tue, 20 Feb 2024 17:19:54 -0700 Shuah Khan <skhan@...uxfoundation.org> wrote:
>>>>>
>>>>>> On 2/19/24 06:53, Marcos Paulo de Souza wrote:
>>>>>>> On Mon, 19 Feb 2024 09:15:15 -0300 Marcos Paulo de Souza <mpdesouza@...e.com> wrote:
>>>>>>>
>>>>>>>> On Mon, 19 Feb 2024 14:35:16 +0800 kernel test robot <lkp@...el.com> wrote:
>>>>>>>>
>>>>>>>>> Hi Marcos,
>>>>>>>>>
>>>>>>>>> kernel test robot noticed the following build errors:
>>>>>>>>>
>>>>>>>>> [auto build test ERROR on 345e8abe4c355bc24bab3f4a5634122e55be8665]
>>>>>>>>>
>>>>>>>>> url:    https://github.com/intel-lab-lkp/linux/commits/Marcos-Paulo-de-Souza/selftests-lib-mk-Do-not-process-TEST_GEN_MODS_DIR/20240216-021601
>>>>>>>>> base:   345e8abe4c355bc24bab3f4a5634122e55be8665
>>>>>>>>> patch link:    https://lore.kernel.org/r/20240215-lp-selftests-fixes-v1-1-89f4a6f5cddc%40suse.com
>>>>>>>>> patch subject: [PATCH 1/3] selftests: lib.mk: Do not process TEST_GEN_MODS_DIR
>>>>>>>>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>>>>>>>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402191417.XULH88Ct-lkp@intel.com/reproduce)
>>>>>>>>>
>>>>>>>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>>>>>>>> the same patch/commit), kindly add following tags
>>>>>>>>> | Reported-by: kernel test robot <lkp@...el.com>
>>>>>>>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202402191417.XULH88Ct-lkp@intel.com/
>>>>>>>>>
>>>>>>>>> All errors (new ones prefixed by >>):
>>>>>>>>>
>>>>>>>>>>> make[3]: *** /lib/modules/5.9.0-2-amd64/build: No such file or directory.  Stop.
>>>>>>>>
>>>>>>>> We should ask the kernel test robot machine owners to install kernel-devel
>>>>>>>> package in order to have this fixed.
>>>>>>>
>>>>>>> Or maybe ask them to change the reproducer to specify KDIR to the git tree,
>>>>>>> instead of /lib/modules/?
>>>>>>>
>>>>>>
>>>>>> This would be a regression to automated test rings. Do you have any other
>>>>>> solutions?
>>>>>
>>>>> I would say that we could skip the these tests if kernel-devel package is not
>>>>> installed. Would it be acceptable? At least we would avoid such issues like this
>>>>> in the future as well.
>>>>>
>>>>
>>>> We have to check and skip build. Something we could do in the livepatch
>>>> Makefile. Can you send patch for this - I will oull this in for next
>>>> so we don't break test rings.
>>>
>>> I added a new patch in the same patchset that would cover this, skipping the
>>> build and test if kernel-devel is not installed. The patchset was sent earlier
>>> today. Please check if the new patch fixes things on the build robot.
>>
>> Hi Shuah, Hi Marcos,
>>
>> Sorry for this wrong report. The files are organized in a different way
>> in the bot and cause this issue. We have fixed the bot to explicitly
>> set KDIR to the correct path before building the selftests. The patch
>> [1] can also work well in bot's environment.
>>
>> [1] https://lore.kernel.org/all/20240221-lp-selftests-fixes-v2-2-a19be1e029a7@suse.com/
> 
> Hi Yujie, thanks for letting us know that the bot had different settings. Either
> way the patch you mentioned should help to reduce noise in the future on
> bot's that doesn't have kernel-devel installed.
> 

Marcos, If you send me the patch, I will apply it to linux-kselftest next.
> Again, thanks a lot for fixing the issue!
>    Marcos
> 

Thank you Yujie

thanks,
--- Shuah