linux-kernel - Re: [PATCH RESEND] cred: Use KMEM_CACHE instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTBhBj0h43UD8s6SBcN2UDh42wqfYHLiNkPmzOWGZEAkg@mail.gmail.com>
Date: Fri, 23 Feb 2024 17:38:24 -0500
From: Paul Moore <paul@...l-moore.com>
To: Kunwu Chan <kunwu.chan@...mail.com>
Cc: axboe@...nel.dk, elena.reshetova@...el.com, chentao@...inos.cn, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] cred: Use KMEM_CACHE instead of kmem_cache_create

On Fri, Feb 23, 2024 at 5:16 AM Kunwu Chan <kunwu.chan@...mail.com> wrote:
>
> From: Kunwu Chan <chentao@...inos.cn>
>
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> ---
>
> Notes:
>     I'am Kunwu.Chan, the problem(https://lore.kernel.org/all/CAHC9VhTJXfPztz2W_V6sp41PJW8dzvZH0YdnRXd7tUZOF1Q09Q@mail.gmail.com/) may be caused by my email server.
>     I change the email and send it to myself, the raw email seems ok.
>     So i resend it.
>
>  kernel/cred.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, that worked much better.  As the prior patch sat for weeks
without any objections I've gone ahead and merged this via the lsm/dev
tree; if anyone has any objections please let me know before the
upcoming merge window.

> diff --git a/kernel/cred.c b/kernel/cred.c
> index c033a201c808..02a96e9d9cfd 100644
> --- a/kernel/cred.c
> +++ b/kernel/cred.c
> @@ -606,8 +606,8 @@ int set_cred_ucounts(struct cred *new)
>  void __init cred_init(void)
>  {
>         /* allocate a slab in which we can store credentials */
> -       cred_jar = kmem_cache_create("cred_jar", sizeof(struct cred), 0,
> -                       SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL);
> +       cred_jar = KMEM_CACHE(cred,
> +                               SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
>  }
>
>  /**
> --
> 2.39.2

-- 
paul-moore.com