[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240223144844667-0800.eberman@hu-eberman-lv.qualcomm.com>
Date: Fri, 23 Feb 2024 14:58:43 -0800
From: Elliot Berman <quic_eberman@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
CC: Alex Elder <elder@...aro.org>,
Srinivas Kandagatla
<srinivas.kandagatla@...aro.org>,
Murali Nalajal <quic_mnalajal@...cinc.com>,
Trilok Soni <quic_tsoni@...cinc.com>,
Srivatsa Vaddagiri
<quic_svaddagi@...cinc.com>,
Carl van Schaik <quic_cvanscha@...cinc.com>,
Philip Derrin <quic_pderrin@...cinc.com>,
Prakruthi Deepak Heragu
<quic_pheragu@...cinc.com>,
Jonathan Corbet <corbet@....net>, Rob Herring
<robh+dt@...nel.org>,
Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Dmitry Baryshkov
<dmitry.baryshkov@...aro.org>,
Fuad Tabba <tabba@...gle.com>,
"Sean
Christopherson" <seanjc@...gle.com>,
Andrew Morton
<akpm@...ux-foundation.org>,
<linux-arm-msm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-mm@...ck.org>
Subject: Re: Re: [PATCH v17 05/35] virt: gunyah: Add hypervisor driver
On Fri, Feb 23, 2024 at 10:10:47PM +0100, Konrad Dybcio wrote:
> On 23.02.2024 00:16, Elliot Berman wrote:
> > Add driver to detect when running under Gunyah. It performs basic
> > identification hypercall and populates the platform bus for resource
> > manager to probe.
> >
> > Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
> > ---
>
> [...]
>
> > +
> > + /* Might move this out to individual drivers if there's ever an API version bump */
> > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) {
> > + pr_info("Unsupported Gunyah version: %u\n",
> > + gunyah_api_version(&gunyah_api));
>
> Weird for this not to be an error, but it's probably not worth resending
> over if it's the only thing
It is an error, but maybe I misunderstood:
> > + /* Might move this out to individual drivers if there's ever an API version bump */
> > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) {
> > + pr_info("Unsupported Gunyah version: %u\n",
> > + gunyah_api_version(&gunyah_api));
> > + return -ENODEV;
> > + }
Powered by blists - more mailing lists