linux-kernel - Re: [PATCH] ARM: dts: imx6ul: Set macaddress location in ocotp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZdkrNfkXGo2pprLW@dragon>
Date: Sat, 24 Feb 2024 07:33:09 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Manuel Traut <manuel.traut@...com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	NXP Linux Team <linux-imx@....com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6ul: Set macaddress location in ocotp

On Thu, Feb 08, 2024 at 01:19:59PM +0100, Manuel Traut wrote:
> If a bootloader does not configure the MAC address, devices come up with
> a random MAC at the moment.
> 
> ocotp provides registers for storing the mac-address.
> Configure those for i.MX6UL and i.MX6ULL allows net/core to retrieve it from
> there.
> 
> Signed-off-by: Manuel Traut <manuel.traut@...com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> index a27a7554c2e7..e5e8bf814f77 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> @@ -538,6 +538,8 @@ fec2: ethernet@...4000 {
>  				fsl,num-rx-queues = <1>;
>  				fsl,stop-mode = <&gpr 0x10 4>;
>  				fsl,magic-packet;
> +				nvmem-cells = <&fec2_mac_addr>;
> +				nvmem-cell-names = "mac-address";
>  				status = "disabled";
>  			};
>  
> @@ -897,6 +899,8 @@ fec1: ethernet@...8000 {
>  				fsl,num-rx-queues = <1>;
>  				fsl,stop-mode = <&gpr 0x10 3>;
>  				fsl,magic-packet;
> +				nvmem-cells = <&fec1_mac_addr>;
> +				nvmem-cell-names = "mac-address";
>  				status = "disabled";
>  			};
>  
> @@ -1004,6 +1008,14 @@ tempmon_temp_grade: temp-grade@20 {
>  				cpu_speed_grade: speed-grade@10 {
>  					reg = <0x10 4>;
>  				};

Have a newline between nodes.

> +				fec1_mac_addr: mac-addr@88 {
> +					reg = <0x88 6>;
> +				};
> +
> +				fec2_mac_addr: mac-addr@8e {
> +					reg = <0x8e 6>;
> +				};
> +

Dropped this one.

I fixed them up and applied the patch.

Shawn

>  			};
>  
>  			csi: csi@...4000 {
> -- 
> 2.43.0
>