linux-kernel - Re: [PATCH rcu 3/4] arch: Select new NEED_TASKS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 22 Feb 2024 20:57:00 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: rcu@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Heiko Carstens <hca@...ux.ibm.com>, Arnd Bergmann <arnd@...db.de>,
	Douglas Anderson <dianders@...omium.org>,
	Ankur Arora <ankur.a.arora@...cle.com>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH rcu 3/4] arch: Select new NEED_TASKS_RCU Kconfig option

On Thu, Feb 22, 2024 at 08:36:51PM -0500, Steven Rostedt wrote:
> On Thu, 22 Feb 2024 16:26:26 -0800
> "Paul E. McKenney" <paulmck@...nel.org> wrote:
> 
> > Currently, if a Kconfig option depends on TASKS_RCU, it conditionally does
> > "select TASKS_RCU if PREEMPTION".  This works, but requires any change in
> > this enablement logic to be replicated across all such "select" clauses.
> > A new NEED_TASKS_RCU Kconfig option has been created to allow this
> > enablement logic to be in one place in kernel/rcu/Kconfig.
> > 
> > Therefore, select the new NEED_TASKS_RCU Kconfig option instead of the
> > old TASKS_RCU option.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Heiko Carstens <hca@...ux.ibm.com>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Douglas Anderson <dianders@...omium.org>
> > Cc: Ankur Arora <ankur.a.arora@...cle.com>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Thank you!  I will apply on my next rebase.

							Thanx, Paul

> -- Steve
> 
> > ---
> >  arch/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index c91917b508736..154f994547632 100644
> > --- a/arch/Kconfig
> > +++ b/arch/Kconfig
> > @@ -55,7 +55,7 @@ config KPROBES
> >  	depends on MODULES
> >  	depends on HAVE_KPROBES
> >  	select KALLSYMS
> > -	select TASKS_RCU if PREEMPTION
> > +	select NEED_TASKS_RCU
> >  	help
> >  	  Kprobes allows you to trap at almost any kernel address and
> >  	  execute a callback function.  register_kprobe() establishes
> > @@ -104,7 +104,7 @@ config STATIC_CALL_SELFTEST
> >  config OPTPROBES
> >  	def_bool y
> >  	depends on KPROBES && HAVE_OPTPROBES
> > -	select TASKS_RCU if PREEMPTION
> > +	select NEED_TASKS_RCU
> >  
> >  config KPROBES_ON_FTRACE
> >  	def_bool y
>