linux-kernel - Re: [PATCH 0/4] usb: typec: ucsi: Expand SOP/SOP' Discovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 07:34:05 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jameson Thies <jthies@...gle.com>
Cc: heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org, 
	pmalani@...omium.org, bleung@...gle.com, abhishekpandit@...omium.org, 
	andersson@...nel.org, fabrice.gasnier@...s.st.com, gregkh@...uxfoundation.org, 
	hdegoede@...hat.com, neil.armstrong@...aro.org, rajaram.regupathy@...el.com, 
	saranya.gopal@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] usb: typec: ucsi: Expand SOP/SOP' Discovery

Hi Jameson,

On Fri, 23 Feb 2024 at 03:04, Jameson Thies <jthies@...gle.com> wrote:
>
> Hi Heikki,
>
> This patch series expands support for partner and cable discover in the
> UCSI driver. There are a few pieces here.
>
> 1. Some cleanup of the GET_CABLE_PROP definitions in ucsi.h.
> 2. Cable discovery and registration with the USB Type-C connector class.
> 3. Partner/Cable identity registration with the USB Type-C connector
> class.
> 4. SOP' alternate mode registration with the USB-C connector class using
> a cable plug.
>
> These have been tested on a v6.6 kernel build running a usermode ppm
> with a Realtek EVB. Let me know if you have any questions.

First and the most obvious comment: 6.6 is four months old. I see that
your base commit is the usb-testing tip, however you declare that you
tested only on 6.6. Now I'm confused. Did you test your patches on top
of usb-testing before sending them?


-- 
With best wishes
Dmitry