linux-kernel - Re: [PATCH RESEND 3/3] mm/zsmalloc: remove get_zspage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 14:48:46 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Chengming Zhou <chengming.zhou@...ux.dev>
Cc: hannes@...xchg.org, Andrew Morton <akpm@...ux-foundation.org>,
	Sergey Senozhatsky <senozhatsky@...omium.org>, nphamcs@...il.com,
	yosryahmed@...gle.com, Minchan Kim <minchan@...nel.org>,
	linux-mm@...ck.org, Chengming Zhou <zhouchengming@...edance.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 3/3] mm/zsmalloc: remove get_zspage_mapping()

On (24/02/20 11:44), Chengming Zhou wrote:
> From: Chengming Zhou <zhouchengming@...edance.com>
> 
> Actually we seldom use the class_idx returned from get_zspage_mapping(),
> only the zspage->fullness is useful, just use zspage->fullness to remove
> this helper.
> 
> Note zspage->fullness is not stable outside pool->lock, remove redundant
> "VM_BUG_ON(fullness != ZS_INUSE_RATIO_0)" in async_free_zspage() since
> we already have the same VM_BUG_ON() in __free_zspage(), which is safe to
> access zspage->fullness with pool->lock held.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>