linux-kernel - Re: [PATCH v4 00/10] KVM: arm64: Avoid serializing LPI get() / put()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86le7b2r9t.wl-maz@kernel.org>
Date: Fri, 23 Feb 2024 14:23:42 +0000
From: Marc Zyngier <maz@...nel.org>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: kvmarm@...ts.linux.dev,
	kvm@...r.kernel.org,
	James Morse <james.morse@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	linux-kernel@...r.kernel.org,
	Eric Auger <eric.auger@...hat.com>
Subject: Re: [PATCH v4 00/10] KVM: arm64: Avoid serializing LPI get() / put()

On Wed, 21 Feb 2024 05:42:43 +0000,
Oliver Upton <oliver.upton@...ux.dev> wrote:
> 
> Addressing a few more goofs that Zenghui was kind enough to point out.
> Clearly all of the bugs have been found and addressed at this point.
> 
> v2: https://lore.kernel.org/kvmarm/20240213093250.3960069-1-oliver.upton@linux.dev/
> v3: https://lore.kernel.org/kvmarm/20240216184153.2714504-1-oliver.upton@linux.dev/
> 
> v3 -> v4:
>  - Actually walk the LPI INTID range in vgic_copy_lpi_list() (Zenghui)
>  - Ensure xa_lock is taken w/ IRQs disabled, even after purging usage of
>    the lpi_list_lock (Zenghui)
>  - Document the lock ordering (Marc)

This is looking good so far. I'll take it for a ride shortly, but in
the meantime:

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.