linux-kernel - Re: [PATCH v15 2/3] iio: adc: ad_sigma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VekP4fJPxcZeQVXypDDrQT1i9CtesN2R4TtiYxxpQr44A@mail.gmail.com>
Date: Fri, 23 Feb 2024 16:42:50 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dumitru Ceclan <mitrutzceclan@...il.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, andy@...nel.org, 
	linux-gpio@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>, 
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Michael Walle <michael@...le.cc>, Arnd Bergmann <arnd@...db.de>, ChiaEn Wu <chiaen_wu@...htek.com>, 
	Niklas Schnelle <schnelle@...ux.ibm.com>, Leonard Göhrs <l.goehrs@...gutronix.de>, 
	Mike Looijmans <mike.looijmans@...ic.nl>, Haibo Chen <haibo.chen@....com>, 
	Hugo Villeneuve <hvilleneuve@...onoff.com>, David Lechner <dlechner@...libre.com>, 
	Ceclan Dumitru <dumitru.ceclan@...log.com>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 2/3] iio: adc: ad_sigma_delta: Add optional irq selection

On Fri, Feb 23, 2024 at 3:38 PM Dumitru Ceclan <mitrutzceclan@...ilcom> wrote:
>
> Add optional irq_num attribute to ad_sigma_delta_info structure for
> selecting the used interrupt line for ADC's conversion completion.

..

>   * @data_reg: Address of the data register, if 0 the default address of 0x3 will
>   *   be used.
>   * @irq_flags: flags for the interrupt used by the triggered buffer
> + * @irq_line: IRQ for reading conversions. If 0, spi->irq will be used
>   * @num_slots: Number of sequencer slots

Now kernel doc order is unaligned with the real member order.
Moreover, have you checked with `pahole`?

>  struct ad_sigma_delta_info {
> @@ -60,6 +61,7 @@ struct ad_sigma_delta_info {
>         unsigned int data_reg;
>         unsigned long irq_flags;
>         unsigned int num_slots;
> +       int irq_line;
>  };

But no need to resend, it's minor and Jonathan can probably amend this
whilst applying.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko