linux-kernel - Re: [PATCH v2] block: fix deadlock between bd_link_disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170869960618.48825.8696438313079266889.b4-ty@kernel.dk>
Date: Fri, 23 Feb 2024 07:46:46 -0700
From: Jens Axboe <axboe@...nel.dk>
To: song@...nel.org, yukuai3@...wei.com, linan666@...weicloud.com
Cc: linux-raid@...r.kernel.org, linux-block@...r.kernel.org, 
 linux-kernel@...r.kernel.org, yi.zhang@...wei.com, houtao1@...wei.com, 
 yangerkun@...wei.com
Subject: Re: [PATCH v2] block: fix deadlock between bd_link_disk_holder and
 partition scan


On Wed, 21 Feb 2024 17:01:22 +0800, linan666@...weicloud.com wrote:
> 'open_mutex' of gendisk is used to protect open/close block devices. But
> in bd_link_disk_holder(), it is used to protect the creation of symlink
> between holding disk and slave bdev, which introduces some issues.
> 
> When bd_link_disk_holder() is called, the driver is usually in the process
> of initialization/modification and may suspend submitting io. At this
> time, any io hold 'open_mutex', such as scanning partitions, can cause
> deadlocks. For example, in raid:
> 
> [...]

Applied, thanks!

[1/1] block: fix deadlock between bd_link_disk_holder and partition scan
      commit: 03f12122b20b6e6028e9ed69030a49f9cffcbb75

Best regards,
-- 
Jens Axboe