linux-kernel - Re: [PATCH v4 2/2] iio: adc: ad7380: new driver for AD7380 ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240224110640.03f3b857@jic23-huawei>
Date: Sat, 24 Feb 2024 11:06:40 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 Michael Hennerich <michael.hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, linux-kernel@...r.kernel.org, Stefan Popa
 <stefan.popa@...log.com>, Julien Stephan <jstephan@...libre.com>
Subject: Re: [PATCH v4 2/2] iio: adc: ad7380: new driver for AD7380 ADCs

On Mon, 19 Feb 2024 13:47:03 -0600
David Lechner <dlechner@...libre.com> wrote:

> On Wed, Jan 10, 2024 at 2:29 PM David Lechner <dlechner@...libre.com> wrote:
> 
> ...
> 
> > +
> > +/* fully differential */
> > +DEFINE_AD7380_DIFFERENTIAL_2_CHANNEL(ad7380_channels, 16);
> > +DEFINE_AD7380_DIFFERENTIAL_2_CHANNEL(ad7381_channels, 14);
> > +/* pseudo differential */
> > +DEFINE_AD7380_DIFFERENTIAL_2_CHANNEL(ad7383_channels, 16);
> > +DEFINE_AD7380_DIFFERENTIAL_2_CHANNEL(ad7384_channels, 14);
> > +  
> 
> Similar question to [1] in light of [2]: Since AD7383 and AD7384 are
> pseudo-differential, should we handle them differently? I.e. add
> aina-supply and ainb-supply DT properties for the negative inputs
> (typically a V_REF / 2 supply) and remove the differential flag from
> the channel spec.
> 
> [1]: https://lore.kernel.org/linux-iio/CAMknhBH2Pqa9xpPxnTCxJegVTbOG-QDeJA4YrQUPfj+hfSs73A@mail.gmail.com/
> [2]: https://lore.kernel.org/linux-iio/CAMknhBF5mAsN1c-194Qwa5oKmqKzef2khXnqA1cSdKpWHKWp0w@mail.gmail.com/

Yes. I think that gives a more intuitive interface for users.
I don't think we need to 'fix' any drivers already upstream as
presenting these as differential is not an ABI error as far as I
am concerned. It's just less than ideal choices given our views
now! (as a result of these discussions on what pseudo differential
means in practice)

Jonathan