linux-kernel - Re: [PATCH v3 3/4] iio: magnetometer: add a driver for Voltafield AF8133J magnetometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240224111633.1485c165@jic23-huawei>
Date: Sat, 24 Feb 2024 11:16:33 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Ondřej Jirman <megi@....cz>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Andrey Skvortsov <andrej.skvortzov@...il.com>,
 Icenowy Zheng <icenowy@...c.io>, Dalton Durst <dalton@...orts.com>, Shoji
 Keita <awaittrot@...k.jp>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] iio: magnetometer: add a driver for Voltafield
 AF8133J magnetometer

Hi Ondřej,

Quick process comment. 

Please crop replies to avoid never ending scrolling and more importantly
a high chance of what you actually want to say being missed!


> > +static int af8133j_probe(struct i2c_client *client)
> > +{

..

> > +	ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
> > +					      &af8133j_trigger_handler, NULL);
> > +	if (ret)
> > +		return dev_err_probe(&client->dev, ret,
> > +				     "Failed to setup iio triggered buffer\n");
> > +
> > +	ret = devm_iio_device_register(dev, indio_dev);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "Failed to register iio device");
> > +
> > +	pm_runtime_get_noresume(dev);
> > +	pm_runtime_use_autosuspend(dev);
> > +	pm_runtime_set_autosuspend_delay(dev, 500);
> > +	ret = devm_pm_runtime_enable(dev);
> > +	if (ret)
> > +		return ret;  
> 
> Ah, forgot to move this up. Oh, well. I'll send v4.
> 
> kind regards,
> 	o.
> 
> > +	pm_runtime_put_autosuspend(dev);
> > +
> > +	return 0;
> > +}
> > +