linux-kernel - Re: [PATCH v3 3/7] ACPI/IORT: Handle memory address size limits as limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab2099fd-b0b7-63d3-bdba-a4462ec230a8@huawei.com>
Date: Sat, 24 Feb 2024 19:43:27 +0800
From: Hanjun Guo <guohanjun@...wei.com>
To: Robin Murphy <robin.murphy@....com>
CC: Vineet Gupta <vgupta@...nel.org>, Russell King <linux@...linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
	Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>, Thomas
 Bogendoerfer <tsbogend@...ha.franken.de>, Paul Walmsley
	<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Sudeep
 Holla <sudeep.holla@....com>, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang
 Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui
	<decui@...rosoft.com>, Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
	David Woodhouse <dwmw2@...radead.org>, Lu Baolu <baolu.lu@...ux.intel.com>,
	Niklas Schnelle <schnelle@...ux.ibm.com>, Matthew Rosato
	<mjrosato@...ux.ibm.com>, Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
	Jean-Philippe Brucker <jean-philippe@...aro.org>, Rob Herring
	<robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, Marek Szyprowski
	<m.szyprowski@...sung.com>, Jason Gunthorpe <jgg@...pe.ca>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-acpi@...r.kernel.org>, <iommu@...ts.linux.dev>,
	<devicetree@...r.kernel.org>, Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH v3 3/7] ACPI/IORT: Handle memory address size limits as
 limits

On 2024/2/10 0:50, Robin Murphy wrote:
> Return the Root Complex/Named Component memory address size limit as an
> inclusive limit value, rather than an exclusive size. This saves having
> to fudge an off-by-one for the 64-bit case, and simplifies our caller.
> 
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> ---
> v2: Avoid undefined shifts (grr...)
> ---
>   drivers/acpi/arm64/dma.c  |  9 +++------
>   drivers/acpi/arm64/iort.c | 20 ++++++++++----------
>   include/linux/acpi_iort.h |  4 ++--
>   3 files changed, 15 insertions(+), 18 deletions(-)

This also makes the code easier to read,

Acked-by: Hanjun Guo <guohanjun@...wei.com>

Thanks
Hanjun