linux-kernel - Re: [PATCH] dax: constify the struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 23 Feb 2024 17:06:01 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: "Ricardo B. Marliere" <ricardo@...liere.net>,
 Dan Williams <dan.j.williams@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>
Cc: nvdimm@...ts.linux.dev, linux-cxl@...r.kernel.org,
 linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] dax: constify the struct device_type usage



On 2/19/24 5:47 AM, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the
> dax_mapping_type variable to be a constant structure as well, placing it
> into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>  drivers/dax/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 1ff1ab5fa105..e265ba019785 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -763,7 +763,7 @@ static const struct attribute_group *dax_mapping_attribute_groups[] = {
>  	NULL,
>  };
>  
> -static struct device_type dax_mapping_type = {
> +static const struct device_type dax_mapping_type = {
>  	.release = dax_mapping_release,
>  	.groups = dax_mapping_attribute_groups,
>  };
> 
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240219-device_cleanup-dax-d82fd0c67ffd
> 
> Best regards,