linux-kernel - Re: [PATCH 3/6] mtd: maps: sun_uflash: Declare uflash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6ed0068-6f04-4a3c-b981-5c27f57985f6@infradead.org>
Date: Fri, 23 Feb 2024 16:30:01 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: sam@...nborg.org, Miquel Raynal <miquel.raynal@...tlin.com>,
 "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: sparclinux@...r.kernel.org, linux-parport@...ts.infradead.org,
 "David S. Miller" <davem@...emloft.net>,
 Andreas Larsson <andreas@...sler.com>, Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] mtd: maps: sun_uflash: Declare uflash_devinit static

On 2/23/24 11:36, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <sam@...nborg.org>
> 
> This fixes the following warning:
> sun_uflash.c:50:5: error: no previous prototype for 'uflash_devinit'
> 
> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Cc: Andreas Larsson <andreas@...sler.com>
> Cc: "David S. Miller" <davem@...emloft.net>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  drivers/mtd/maps/sun_uflash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c
> index f58cfb15d6e8..b69dade3f7ad 100644
> --- a/drivers/mtd/maps/sun_uflash.c
> +++ b/drivers/mtd/maps/sun_uflash.c
> @@ -47,7 +47,7 @@ struct map_info uflash_map_templ = {
>  	.bankwidth =	UFLASH_BUSWIDTH,
>  };
>  
> -int uflash_devinit(struct platform_device *op, struct device_node *dp)
> +static int uflash_devinit(struct platform_device *op, struct device_node *dp)
>  {
>  	struct uflash_dev *up;
>  
> 

-- 
#Randy