linux-kernel - Re: [PATCH v5 0/6] clk: hisilicon: add support for Hi3798MV200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 24 Feb 2024 22:25:04 +0800
From: Yang Xiwen <forbidden405@...look.com>
To: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: David Yang <mmyangfl@...il.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v5 0/6] clk: hisilicon: add support for Hi3798MV200

On 2/24/2024 1:12 AM, Yang Xiwen via B4 Relay wrote:
> This SoC is similar to Hi3798CV200 with a few more clocks in CRG module.
>
> Note this driver is still ongoing, many clocks are not registered in the
> driver now. Feedback is welcomed, especially from HiSilicon people.
>
> Signed-off-by: Yang Xiwen <forbidden405@...look.com>
> ---
> Changes in v5:
> - sort compatibles alphabetically (Rob Herring)
> - squash patch 5&6 (Rob Herring)
> - Link to v4: https://lore.kernel.org/r/20240223-clk-mv200-v4-0-3e37e501d407@outlook.com
>
> Changes in v4:
> - dt-bindings: hisi-crg: add reg and #reset-cells to required, add reset-controller to required for cv200
> - dt-bindings: hisi-crg: do not add "simple-mfd" and "syscon" for hi3519 (Krzysztof Kozlowski)
> - dt-bindings: hi3798mv200: replace spaces with tabs (Krzysztof Kozlowski)
> - dt-bindings: s/DTS/DT_BINDINGS_CLOCK (Krzysztof Kozlowski)
> - Link to v3: https://lore.kernel.org/r/20240222-clk-mv200-v3-0-f30795b50318@outlook.com
>
> Changes in v3:
> - remove RFC (Krzysztof Kozlowski)
> - rearrange patches so dt-binding comes before drivers (Krzysztof Kozlowski)
> - dt-bindings: Remove lots of properties
> - dt-bindings: stop merging all hisi-clock bindings, only convert hisi-crg.txt for now.
> - dt-bindings: remove hisilicon,hisi-sdmmc-dll subnode (Rob Herring, Krzysztof Kozlowski)
> - split histb-clock.h into two files, deprecate this header file
> - fix all users (hi3798cv200.dtsi and hi3798cv200 CRG driver)
> - hi3798mv200-crg: add a few missing clocks
> - Link to v2: https://lore.kernel.org/r/20240217-clk-mv200-v2-0-b782e4eb66f7@outlook.com
>
> Changes in v2:
> - s/dt-binding/dt-bindings in commit logs: (Krzysztof Kozlowski)
> - fix bot error by adding "hisilicon,hisi-sdmmc-dll" to syscon.yaml (Rob Herring)
> - hi3798mv200-crg: assign fixed rate parents to some gates
> - hi3798mv200-crg: s/ETH/FEMAC, add GMAC ctrl clock
> - Link to v1: https://lore.kernel.org/r/20240216-clk-mv200-v1-0-a29ace29e636@outlook.com
>
> ---
> Yang Xiwen (6):
>        dt-bindings: clock: convert hisi-crg.txt to YAML
>        dt-bindings: clock: histb-clock: split into two header files
>        arm64: dts: hisilicon: fix include path
>        clk: hisilicon: fix include path for crg-hi3798cv200
>        dt-bindings: clock: hisilicon,hisi-crg: add Hi3798MV200 SoC
>        clk: hisilicon: add CRG driver for Hi3798MV200 SoC
>
>   .../devicetree/bindings/clock/hisi-crg.txt         |  50 ---
>   .../bindings/clock/hisilicon,hisi-crg.yaml         |  76 ++++
>   arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi     |   3 +-
>   drivers/clk/hisilicon/Kconfig                      |   8 +
>   drivers/clk/hisilicon/Makefile                     |   1 +
>   drivers/clk/hisilicon/crg-hi3798cv200.c            |   3 +-
>   drivers/clk/hisilicon/crg-hi3798mv200.c            | 462 +++++++++++++++++++++
>   .../dt-bindings/clock/hisilicon,hi3798cv200-crg.h  |  62 +++
>   .../clock/hisilicon,hi3798cv200-sysctrl.h          |  17 +
>   .../dt-bindings/clock/hisilicon,hi3798mv200-crg.h  | 150 +++++++
>   .../clock/hisilicon,hi3798mv200-sysctrl.h          |  21 +
>   include/dt-bindings/clock/histb-clock.h            |  70 +---
>   12 files changed, 810 insertions(+), 113 deletions(-)
> ---
> base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d
> change-id: 20240216-clk-mv200-cc8cae396ee0
>
> Best regards,


Please do not merge this series. Some critical clocks are found missing. 
dt-binding indexes needs update.

-- 
Regards,
Yang Xiwen