linux-kernel - Re: [PATCH v2 1/2] crypto: ccp: Avoid discarding errors in psp_send_platform_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zdk9SQMV4tyxyTEU@gondor.apana.org.au>
Date: Sat, 24 Feb 2024 08:50:17 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Tom Lendacky <thomas.lendacky@....com>, John Allen <john.allen@....com>,
	"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..." <linux-crypto@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Tim Van Patten <timvp@...gle.com>
Subject: Re: [PATCH v2 1/2] crypto: ccp: Avoid discarding errors in
 psp_send_platform_access_msg()

On Tue, Feb 13, 2024 at 11:34:28AM -0600, Mario Limonciello wrote:
> Errors can potentially occur in the "processing" of PSP commands or
> commands can be processed successfully but still return an error code in
> the header.
> 
> This second case was being discarded because PSP communication worked but
> the command returned an error code in the payload header.
> 
> Capture both cases and return them to the caller as -EIO for the caller
> to investigate. The caller can detect the latter by looking at
> `req->header->status`.
> 
> Reported-and-tested-by: Tim Van Patten <timvp@...gle.com>
> Fixes: 7ccc4f4e2e50 ("crypto: ccp - Add support for an interface for platform features")
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v1->v2:
>  * Update tag for Tim
>  * Reword commit message
> ---
>  drivers/crypto/ccp/platform-access.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt